RFR: 8230109: G1DirtyCardQueueSet should use card counts rather than buffer counts

Kim Barrett kim.barrett at oracle.com
Mon Aug 26 15:42:29 UTC 2019


> On Aug 26, 2019, at 4:52 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
>> 
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8230109
>> 
>> Webrev:
>> http://cr.openjdk.java.net/~kbarrett/8230109/open.00/
> 
> I really like the cleanups you’ve done in this area of the code base and this one is no exception. Looks good, just one question around the different G1ConcRefinement-flags (threshold and zones). Couldn’t we make these be number of cards and get rid of the buffers_to_cards conversion in g1ConcurrentRefine.cpp?

Those are product options; changing their semantics like that is not so easy.




More information about the hotspot-gc-dev mailing list