RFR: 8230109: G1DirtyCardQueueSet should use card counts rather than buffer counts

[Kim Barrett]

> On Aug 29, 2019, at 5:26 PM, sangheon.kim at oracle.com wrote:
> 
> Hi Kim,
> 
> On 8/27/19 7:54 AM, Kim Barrett wrote:
>>> On Aug 27, 2019, at 3:34 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
>>> 
>>> 
>>> 
>>>> 26 aug. 2019 kl. 22:48 skrev Kim Barrett <kim.barrett at oracle.com>:
>>>> 
>>>>> On Aug 26, 2019, at 2:29 PM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
>>>>> 
>>>>> 
>>>>> 
>>>>>> 26 aug. 2019 kl. 17:42 skrev Kim Barrett <kim.barrett at oracle.com>:
>>>>>> 
>>>>>>> On Aug 26, 2019, at 4:52 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
>>>>>>>> CR:
>>>>>>>> https://bugs.openjdk.java.net/browse/JDK-8230109
>>>>>>>> 
>>>>>>>> Webrev:
>>>>>>>> http://cr.openjdk.java.net/~kbarrett/8230109/open.00/
>>>>>>> I really like the cleanups you’ve done in this area of the code base and this one is no exception. Looks good, just one question around the different G1ConcRefinement-flags (threshold and zones). Couldn’t we make these be number of cards and get rid of the buffers_to_cards conversion in g1ConcurrentRefine.cpp?
>>>>>> Those are product options; changing their semantics like that is not so easy.
>>>>>> 
>>>>> True, but I think it is something we want to do in the longer run so maybe creating an enhancement for it to track it?
>>>> Maybe, and maybe not.
>>>> 
>>>> […]
>>>> 
>>>> So I'd prefer they were left alone until such time as we have a better
>>>> understanding of what we actually want / need here.
>>>> 
>>> Sounds like a good plan, and let’s hope we can figure out some good names :)
>> Thanks.
> Looks good to me too.
> 
> Thanks,
> Sangheon

Thanks.