RFR(T): 8230327: Make G1DirtyCardQueueSet free-id init unconditional

Thomas Schatzl thomas.schatzl at oracle.com
Fri Aug 30 07:43:53 UTC 2019


Hi,

On 29.08.19 20:35, Kim Barrett wrote:
>> On Aug 29, 2019, at 5:49 AM, Leo Korinth <leo.korinth at oracle.com> wrote:
>>
>> On 29/08/2019 02:27, Kim Barrett wrote:
>>> Please review this trivial cleanup of G1DirtyCardQueueSet
>>> initialization. With the separation of G1RedirtyCardsQueueSet from
>>> G1DirtyCardQueueSet, the latter is now a singleton class that should
>>> always have an associated G1FreeIdSet.  We can now unconditionally
>>> construct that object when constructing the DCQS.
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8230327
>>> Webrev:
>>> http://cr.openjdk.java.net/~kbarrett/8230327/open.00/
>>> Testing:
>>> Local (linux-x64) hotspot:tier1.
>>
>>
>> Looks good! How about making G1FreeIdSet inline instead of a pointer? I am fine with either.
> 
> Sure.
> 
> New webrevs:
> full: http://cr.openjdk.java.net/~kbarrett/8230327/open.01/
> incr: http://cr.openjdk.java.net/~kbarrett/8230327/open.01.inc/
> 

   looks good.

Thomas



More information about the hotspot-gc-dev mailing list