RFR (S): 8235341: Improve WorkerDataArray API to disallow separate instantiation of sub-items

Stefan Johansson stefan.johansson at oracle.com
Thu Dec 5 12:49:50 UTC 2019



> 5 dec. 2019 kl. 11:25 skrev Thomas Schatzl <thomas.schatzl at oracle.com>:
> 
> Hi Stefan,
> 
>  thanks for your review.
> 
> On 05.12.19 11:10, Stefan Johansson wrote:
>> Hi Thomas,
>>> 5 dec. 2019 kl. 10:27 skrev Thomas Schatzl <thomas.schatzl at oracle.com>:
>>> 
>>> Hi all,
>>> 
>>>  can I have reviews for this follow-up change of JDK-8235247 that improve[...]
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8235341
>>> Webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8235341/webrev/
>> Really nice cleanup. Everything looks good, but I would prefer if we renamed add_thread_work_items to create_thread_work_items.
> 
> Fixed:
> 
> http://cr.openjdk.java.net/~tschatzl/8235341/webrev.0_to_1 (diff)
> http://cr.openjdk.java.net/~tschatzl/8235341/webrev.1/ (full)
> 
Looks good,
StefanJ

> (In the incremental webrev, the webrev tool somehow messed up with src/hotspot/share/gc/shared/workerDataArray.inline.hpp - the change does not add that file...). The full webrev is okay.
> 
> Thanks,
>  Thomas




More information about the hotspot-gc-dev mailing list