RFR (trivial): 8235819: -Wformat-overflow is reported from GCC 9

Thomas Schatzl thomas.schatzl at oracle.com
Fri Dec 13 19:28:49 UTC 2019


Hi,

On 13.12.19 15:42, Yasumasa Suenaga wrote:
> Hi Leo,
> 
> Thanks for clarifying.
> I continue to wait Reviewer for webrev.00 .
> 
>>>>>    webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8235819/webrev.00/
> 

   I would prefer to implement Leo's suggestion.

Looking at the code, the warning is a false positive, as in actual 
execution the index never goes to 5 (e.g. YoungFreeCSet does not have 
sub-items afaict), and the _work_items != NULL check prevents it from 
being an actual issue.

I am open to making GCC happy by extending the array *if* the manual 
check/assert does not help, which gcc very likely does not recognize, too.

Thanks,
   Thomas



More information about the hotspot-gc-dev mailing list