PING: Re: RFR: JDK-8214236: sun.gc.collector.2.name should be changed

[Chihiro Ito]

Hi Thomas and Per,

Could you review this?

webrev:
http://cr.openjdk.java.net/~cito/JDK-8214236/webrev.02/

JBS:
https://bugs.openjdk.java.net/browse/JDK-8214236

Regards,
Chihiro

On 2019/01/31 22:13, Chihiro Ito wrote:
> Hi Thomas and Per,
>
> I renamed counter names as follows referencing jstat. Could you review 
> these?
>
> -XX:+UseSerialGC
> sun.gc.collector.0.name="Serial young collection pauses"
> sun.gc.collector.1.name="Serial full collection pauses"
>
> -XX:+UseParallelGC
> sun.gc.collector.0.name="Parallel young collection pauses"
> sun.gc.collector.1.name="Parallel full collection pauses"
>
> -XX:+UseParallelGC -XX:-UseParallelOldGC
> sun.gc.collector.0.name="Parallel young collection pauses"
> sun.gc.collector.1.name="Serial full collection pauses"
>
> -XX:+UseConcMarkSweepGC
> sun.gc.collector.0.name="CMS young collection pauses"
> sun.gc.collector.1.name="CMS full collection pauses"
> sun.gc.collector.2.name="CMS concurrent cycle pauses"
>
> -XX:+UseG1GC
> sun.gc.collector.0.name="G1 young collection pauses"
> sun.gc.collector.1.name="G1 full collection pauses"
> sun.gc.collector.2.name="G1 concurrent cycle pauses"
>
> -XX:+UnlockExperimentalVMOptions -XX:+UseZGC
> sun.gc.collector.2.name="Z concurrent cycle pauses"
>
>
> I uploaded webrev. I already have run the changes through test-tier1 
> test sets and saw no sign of regression.
>
> webrev:
> http://cr.openjdk.java.net/~cito/JDK-8214236/webrev.02/
>
> JBS:
> https://bugs.openjdk.java.net/browse/JDK-8214236
>
> Regards,
> Chihiro
>
>
>
> On 2019/01/16 23:49, Chihiro Ito wrote:
>> Hi Thomas,
>>
>> I try to rename for all collections.
>>
>> Regards,
>> Chihiro
>>
>> On 2019/01/16 22:41, Thomas Schatzl wrote:
>>> Hi Chihiro,
>>>
>>> On Wed, 2019-01-16 at 00:30 +0900, Chihiro Ito wrote:
>>>> Hi Thomas and Per,
>>>>
>>>> I fixed counter name in G1, CMS and Z.
>>>> Could you review it ?
>>>>
>>>> http://cr.openjdk.java.net/~cito/JDK-8214236/webrev.01/
>>>>
>>>>
>>>> For your information, output of PerfCounter.print is following.
>>>>
>>>> G1GC:
>>>> sun.gc.collector.0.name="G1 incremental collection pauses"
>>>> sun.gc.collector.1.name="G1 full collection pauses"
>>>> sun.gc.collector.2.name="G1 concurrent cycle pauses"
>>>>
>>>> CMS:
>>>> sun.gc.collector.2.name="CMS concurrent cycle pauses"
>>>>
>>>> ZGC:
>>>> sun.gc.collector.2.name="Z concurrent cycle pauses"
>>> Fine with me - since we are there, maybe you are interested in
>>> revisiting the names for the other CollectorCounters too?
>>>
>>> I found the following:
>>>
>>> Parallel GC:
>>>
>>> "PSScavenge"
>>> "PSParallelCompact"
>>> "PSMarkSweep"
>>>
>>> CMS:
>>>
>>> "CMS"
>>> "MSC"
>>>
>>> Serial:
>>>
>>> "PCopy" (I have no idea what this is supposed to be; this is serial
>>> young gc)
>>>
>>> We can skip them too if we can't find better names.
>>>
>>> Thanks,
>>>    Thomas
>>>
>>>
>>>
>>
>>
>