RFR (S/M): 8219096: Merge print_termination_stats code with current logging

Kim Barrett kim.barrett at oracle.com
Fri Feb 15 21:31:39 UTC 2019


> On Feb 15, 2019, at 8:43 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi,
> 
>  can I have reviews for this change that merges the termination
> statistics into the regular log file (there were only two metrics left,
> LAB waste and LAB undo waste), and remove the termination stats
> afterwards?
> 
> I (very) rarely use these metrics, so I thought it would be better to
> keep them (and not just removing the entire termination stats).
> 
> I was undecided whether it would be good to hide these under the
> gc+phases=trace level though, so opinions welcome.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8219096
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8219096/webrev/
> Testing:
> log output verification, test case update
> 
> Thanks,
>  Thomas

Looks good.




More information about the hotspot-gc-dev mailing list