RFR (XS): 8216316: Tests fail due to too low specified TLAB size [Was: Re: RFR (XS): 8216316: jdk/jfr/event/gc/detailed/TestPromotionEventWithG1.java fails due to reserved TLAB area too large]

Lindenmaier, Goetz goetz.lindenmaier at sap.com
Wed Jan 9 11:49:17 UTC 2019


Looks good, thanks for including this!!

The G1 test needs the copyright adapted. Don't need a new webrev for this. 

Will you push this to 12 or 13?  I see both bugs in 12, too.

Best regards,
  Goetz.

> -----Original Message-----
> From: Thomas Schatzl <thomas.schatzl at oracle.com>
> Sent: Mittwoch, 9. Januar 2019 12:43
> To: Lindenmaier, Goetz <goetz.lindenmaier at sap.com>; hotspot-gc-
> dev at openjdk.java.net
> Subject: Re: RFR (XS): 8216316: Tests fail due to too low specified TLAB size
> [Was: Re: RFR (XS): 8216316:
> jdk/jfr/event/gc/detailed/TestPromotionEventWithG1.java fails due to
> reserved TLAB area too large]
> 
> Hi Goetz,
> 
> On Wed, 2019-01-09 at 08:04 +0000, Lindenmaier, Goetz wrote:
> > Hi Thomas,
> >
> > all our test passed with your patch.
> >
> > But I found a similar issue:
> > TestVerifyStackAfterDeopt.java says:
> > MinTLABSize (1024) must be greater than or equal to reserved area in
> > TLAB (1280)
> >
> 
> I added the fix to the test to this webrev.
> 
> New webrev:
> http://cr.openjdk.java.net/~tschatzl/8216316/webrev.1/
> 
> Thanks,
>   Thomas
> 



More information about the hotspot-gc-dev mailing list