RFR 8215299: Remove G1CMTask::should_exit_termination()'s undesirable side-effect
zgu at redhat.com
zgu at redhat.com
Mon Jan 14 13:21:00 UTC 2019
Thanks again, Kim.
> > >
> -------------------------------------------------------------------
> -----------
> src/hotspot/share/gc/g1/g1ConcurrentMark.hpp
> 733 // Set abort flag if above check fails
>
> Rather than "above", actually refer to regular_clock_call by name.
> I don't need to review again for this.
Will fix before push.
> -------------------------------------------------------------------
> -----------
> src/hotspot/share/gc/g1/g1ConcurrentMark.hpp
> 734 inline void abort_marking_if_regular_check_fail();
>
> I'm not wild about this name, but don't have a better suggestion.
> Maybe another reviewer will suggest something. Otherwise, go
> ahead with this name.
May I get a second review?
Thanks,
-Zhengyu
>
>
> -------------------------------------------------------------------
> -----------
>
> Looks good.
>
More information about the hotspot-gc-dev
mailing list