RFR (S) 8217423: Windows gtest build fails after JDK-8212826 (Make PtrQueue free list lock-free)

Langer, Christoph christoph.langer at sap.com
Sun Jan 20 21:28:21 UTC 2019


Hi Aleksey,

the rename looks reasonable to me. Thanks for fixing.

Best regards
Christoph

> -----Original Message-----
> From: hotspot-gc-dev <hotspot-gc-dev-bounces at openjdk.java.net> On
> Behalf Of Aleksey Shipilev
> Sent: Sonntag, 20. Januar 2019 21:40
> To: hotspot-gc-dev at openjdk.java.net
> Subject: RFR (S) 8217423: Windows gtest build fails after JDK-8212826 (Make
> PtrQueue free list lock-free)
> 
> Bug:
>   https://bugs.openjdk.java.net/browse/JDK-8217423
> 
> Fix:
>   http://cr.openjdk.java.net/~shade/8217423/webrev.01/
> 
> Current Windows build is broken. This patch fixes it by renaming the test
> typedef to resolve the
> name conflict with the actual Stack. I suspect that definition comes via
> precompiled.hpp, but
> regardless, including stack.hpp accidentally should not break the test. Let's
> instead use the
> special name for test typedef.
> 
> Testing: {Linux, Windows} x86_64 build, gtest; jdk-submit (running)
> 
> Thanks,
> -Aleksey



More information about the hotspot-gc-dev mailing list