RFR: 8217257: ZGC: Minor cleanup of ZBarrierSetC2
Per Liden
per.liden at oracle.com
Tue Jan 22 09:58:42 UTC 2019
On 1/22/19 10:53 AM, Stefan Karlsson wrote:
> Hi Per,
>
> On 2019-01-16 15:59, Per Liden wrote:
>> Minor style/cosmetic cleanups of ZBarrierSetC2.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8217257
>> Webrev: http://cr.openjdk.java.net/~pliden/8217257/webrev.0
>
> This change contains cleanups and they look good. However, the patch
> also contains a bug fix in ZBarrierSetC2::escape_add_final_edges (a
> missing break causing a fall-through in the switch statement), and I'd
> like to see that getting fixed as a separate changeset.
Thanks for reviewing Stefan.
Filed and sent out https://bugs.openjdk.java.net/browse/JDK-8217503 to
deal with the fall through bug.
Updated this webrev accordingly:
http://cr.openjdk.java.net/~pliden/8217257/webrev.1
/Per
>
> Thanks,
> StefanK
>
>>
>> /Per
More information about the hotspot-gc-dev
mailing list