RFR(XXS) 8217794: Improve termination detection in owstTaskTerminator
zgu at redhat.com
zgu at redhat.com
Tue Jan 29 16:54:06 UTC 2019
Hi,
It turns out to be a bug after it was split from JDK-8215047.
Please see the bug for details.
I changed bug synopsis to "Missing termination check results violation
of termination invariant" and updated Prirority to P2.
Could I get a second reivew ASAP, so it can unbreak the mainline.
There is no change to the fix.
Thanks,
-Zhengyu
On Mon, 2019-01-28 at 16:04 +0100, Thomas Schatzl wrote:
> Hi,
>
> On Mon, 2019-01-28 at 09:56 -0500, zgu at redhat.com wrote:
> > Hi,
> >
> > Could I get review for this small enhancement, that may improve
> > termination dectection?
> >
> > This is *not* a correctness issue, but latency improvement. Since
> > it
> > already holds lock, it is worth a quick check for termination
> > condition.
> >
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8217794
> > Webrev: http://cr.openjdk.java.net/~zgu/JDK-8217794/webrev.00/
> >
> > Test:
> > hotspot_gc on Linux x64 (fastdebug and release)
> > Submit tests
>
> looks good.
>
> Fyi (for other reviewers) I tested (and reviewed) this change already
> as part of some early version of JDK-8215047.
>
> Thanks,
> Thomas
>
>
More information about the hotspot-gc-dev
mailing list