RFR: 8224659: Parallel GC: Use WorkGang (1: PCRefProcTask)

[Leo Korinth]

On 03/07/2019 11:27, Thomas Schatzl wrote:
> Hi,
> 
> On Tue, 2019-07-02 at 16:59 -0400, Kim Barrett wrote:
>>> On Jun 28, 2019, at 12:30 PM, Leo Korinth <leo.korinth at oracle.com>
>>> wrote:
>>>
>>> Hi!
>>>
>>> Here are some updates on the patch series.
>>>
>>> http://cr.openjdk.java.net/~lkorinth/workgang/1/
>>>
>>> Running some tests on them now.
>>>
>>> Thanks,
>>> Leo
>>
>>
> http://cr.openjdk.java.net/~lkorinth/workgang/1/_8224659-Parallel-GC-Use-WorkGang-1-PCRefProcTask/
>>
> http://cr.openjdk.java.net/~lkorinth/workgang/1/_8224659-Parallel-GC-Use-WorkGang-1-PCRefProcTask-fixup-1/
>>
>> This part looks good.
>>
> 
>    some (very) minor nits. Sorry for all of them being indentation
> issues:
> 
> parallelScavengeHeap.hpp:line 100+ - the indentation is broken, i.e.
> extra space. This is kind-of pre-existing, but the change continued
> with the broken indentation.

Will fix.

> 
> psParallelCompact.cpp:1793: the arguments to the call to
> WorkerPolicy::calc_active_workers() should be indented according to it,
> not the outer method.
> 
> An easy way to avoid all code moving to the right would be introducing
> a local temporary variable. >
> E.g. it may also be useful to put the expression
> ParallelScavengeHeap::heap()->workers() into a local variable to avoid
> excessive spacing.
> 
> psScavenge.cpp:342: same as above

Will fix (probably by indenting more if that is okay).

> 
> Looks good otherwise.
> 
> Thanks,
>    Thomas
> 

Thanks Kim and Thomas,
Leo