RFR: 8217170: gc/arguments/TestUseCompressedOopsErgo.java timed out

[Thomas Schatzl]

Hi,

On Sat, 2019-07-06 at 17:45 -0400, Kim Barrett wrote:
> Please review this change to many of the tests in gc/arguments to
> reduce the chances of some of them timing out on some platform
> configurations, especially when run with debug builds.
> 
[..]
> To address the problem there is a new helper class, GCArguments,
> which provides wrappers around ProcessTools.createJavaProcessBuilder
> to add options to disable those problematic features.  The options
> are added at the front, so they can be re-enabled by later options
> from a test if desired (such as the test that checks
> VerifyBeforeExit).  The tests have been updated to call that new
> wrapper.
> 
> There is still some residual odd slowness to at least some of these
> tests.  The child processes usually take 10's to low 100's of
> milliseconds to run, but sometimes 3-5 seconds (or 20+ seconds when
> using CMS; don't know what's up with that).  So there's further
> investigation to be done, but the changes being made here at least
> reduce the spurious timeout noise in regression testing.

There are a few other trueInDebug flags, but apart from
ZapFillerObjects there is nothing obvious. And even that seems doubtful
to cause issues.

> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8217170
> 
> Webrev:
> http://cr.openjdk.java.net/~kbarrett/8217170/open.00/
> 

looks good.

Thomas