RFR (S): 8227179: Test for new gc+metaspace=info output format

Tony Printezis tprintezis at twitter.com
Mon Jul 8 15:09:57 UTC 2019


Thanks for pointing that out, Thomas. Updated webrev (the only change is
the @test comments at the top):

http://cr.openjdk.java.net/~tonyp/8227179/webrev.1/

I tested it with a “normal” build (all GCs built) and one with no CMS and
the test seemed to have done the right thing in both occasions.

Tony


—————
Tony Printezis | @TonyPrintezis | tprintezis at twitter.com


On July 8, 2019 at 3:54:50 AM, Thomas Schatzl (thomas.schatzl at oracle.com)
wrote:

Hi Tony,

On Wed, 2019-07-03 at 12:57 -0700, Tony Printezis wrote:
> Hi all,
>
> This is a follow-up to:
>
> 8223575: add subspace transitions to gc+metaspace=info log lines
>
> (that I just pushed) and adds a test to sanity check the
> gc+metaspace=info
> output. Webrev here:
>
> http://cr.openjdk.java.net/~tonyp/8227179/webrev.0/
>

test looks good except for some issue with builds that do not build
all GCs.

I.e. you need to split the single @test block into multiple, for each
collector one and add a @requires tag. E.g. gc/TestSystemGC.java shows
how to do that.

Thanks,
Thomas



More information about the hotspot-gc-dev mailing list