RFR (S): 8226232: Move merge heap roots code out from G1RemSetScanState

Kim Barrett kim.barrett at oracle.com
Thu Jul 11 21:16:23 UTC 2019


> On Jul 11, 2019, at 3:12 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
>> On Jul 10, 2019, at 11:30 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>> […]
>> CR:
>> https://bugs.openjdk.java.net/browse/JDK-8226232
>> Webrev:
>> http://cr.openjdk.java.net/~tschatzl/8226232/webrev/
>> Testing:
>> hs-tier1-5
>> 
> 
> Looks good.
> 
> One small item:
> 
> ------------------------------------------------------------------------------
> src/hotspot/share/gc/g1/g1RemSet.cpp
> 1166   {
> 1167     _scan_state->prepare_for_merge_heap_roots();
> 1168   }
> 
> Leftover extra scope nesting?
> 
> ------------------------------------------------------------------------------

Looking at the RFR for 8227084, that extra scope is used for timing-related code.
So never mind, the extra scope nesting is fine.





More information about the hotspot-gc-dev mailing list