RFR 8225483: Shenandoah: Enhance native access barrier

Roman Kennke rkennke at redhat.com
Mon Jul 15 13:12:48 UTC 2019


>>> Am 11. Juni 2019 16:25:21 MESZ schrieb Zhengyu Gu <zgu at redhat.com>:
>>>      Updated: http://cr.openjdk.java.net/~zgu/JDK-8225483/webrev.02/
>>>      Okay now?
>>
>> I still do not like ASSERT around the declaration/definition. What
>> prevents us from making that
>> method available in both release/debug? That would certainly simplify
>> debugging: we would execute
>> the same code in both configurations.
> 
> Rebased on Roman's JDK-8226695 fix and made
> SHBS::oop_store_not_in_heap() available for both configurations, as
> suggested by Aleksey.
> 
> http://cr.openjdk.java.net/~zgu/JDK-8225483/webrev.03/
> 
> Reran hotspot_gc_shenandoah (fastdebug and release)
> 

Looks good to me.

Thanks,
Roman




More information about the hotspot-gc-dev mailing list