RFR (S): 8227084: Add timing information for merge heap root preparation

sangheon.kim at oracle.com sangheon.kim at oracle.com
Mon Jul 15 21:12:14 UTC 2019


Hi Thomas,

On 7/10/19 8:36 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this change that adds timing information for
> parts of the Merge Heap Roots phase as preparation for JDK-8226913.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8227084
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8227084
Looks good.

Just minor knit:

419 debug_time("Prepare Merge Heap Roots", 
_cur_optional_prepare_merge_heap_roots_time_ms);
434 debug_time("Prepare Merge Heap Roots", 
_cur_prepare_merge_heap_roots_time_ms);

- Line 419 seems to include 'optional'? I don't need extra webrev for this.

Thanks,
Sangheon


> Testing:
> hs-tier1-5
>
> Thanks,
>    Thomas
>
>




More information about the hotspot-gc-dev mailing list