RFR (S): 8226232: Move merge heap roots code out from G1RemSetScanState

Thomas Schatzl thomas.schatzl at oracle.com
Tue Jul 16 09:26:48 UTC 2019


Hi,

On Fri, 2019-07-12 at 13:07 -0700, sangheon.kim at oracle.com wrote:
> Hi Thomas,
> 
> On 7/10/19 8:30 AM, Thomas Schatzl wrote:
> > Hi all,
> > 
> >    can I have reviews for this small change that moves code related
> > to the merge heap roots phase out of G1RemSetScanState? This imho
> > significantly increases readability of G1RemSetScanState.
> > 
> > More minor cleanups to improve the code are planned, but I think it
> > is good to take it in steps.
> > 
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8226232
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8226232/webrev/
> 
> Looks good.

  thanks for your review.

Thomas





More information about the hotspot-gc-dev mailing list