RFR 8227635: Shenandoah: SHBSA::load_at() needs to deal IN_NATIVE load

Roman Kennke rkennke at redhat.com
Tue Jul 16 15:27:51 UTC 2019


There seem to be gratituous whitespace changes in :

src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp
and
src/hotspot/cpu/x86/gc/shenandoah/shenandoahBarrierSetAssembler_x86.hpp

Other than that, looks good. I will look at the traversal issue, I am
not quite sure how this needs to be treated.

Roman


> Please review this updated webrev:
> 
> http://cr.openjdk.java.net/~zgu/JDK-8227635/webrev.01/
> 
> 
> 1) As Roland suggested, don't save vector registers.
> 
> 2) Renamed oop_load_natiev_barrier() to load_reference_barrier_native()
> to be consistent with current Roman's naming changes.
> 
> 3) Use is_traversal_mode() instead of
> is_concurrent_traversal_in_progress(), due to recent traversal GC changes.
> 
> 4) Restore old traversal behavior, disregard NO_KEEPALIVE decorator.
> 
> Test:
> 
>   hotspot_gc_shenandoah (fastdebug and release) on Linux x86_64 and
> aarch64.
> 
> 
> -Zhengyu
> 
> 
> 
> On 7/15/19 3:17 AM, Roland Westrelin wrote:
>>
>>> Webrev: http://cr.openjdk.java.net/~zgu/JDK-8227635/webrev.00/index.html
>>
>> Do you really need to save vector registers? Isn't this called from the
>> interpreter only?
>>
>> Roland.
>>




More information about the hotspot-gc-dev mailing list