RFR 8227866: Shenandoah: Split weak root processing and class unloading in parallel cleaning task
Zhengyu Gu
zgu at redhat.com
Mon Jul 22 11:50:09 UTC 2019
On 7/22/19 7:30 AM, Roman Kennke wrote:
> Yes, I think it should still remain in gc/shared as long as Shenandoah
> is using (parts of) it.
Thanks for reviewing, Roman.
I think we will just move "ParallelCleaningTask" back to G1 and keep
subtasks in shared.
Thanks,
-Zhengyu
>
> The change looks good to me.
>
> Thanks,
> Roman
>
>
>> Hi Thomas,
>>
>> Although, Shenandoah no long uses ParallelCleaningTask, it still uses
>> tasks defined in it, such as StringDedupCleaningTask,
>> CodeCacheUnloadingTask and etc. So, it should still remain in "shared".
>>
>> What you think?
>>
>> Thanks,
>>
>> -Zhengyu
>>
>>
>>
>> On 7/18/19 6:02 AM, Thomas Schatzl wrote:
>>> Hi,
>>>
>>> On Wed, 2019-07-17 at 14:13 -0400, Zhengyu Gu wrote:
>>>>
>>>> On 7/17/19 2:03 PM, Thomas Schatzl wrote:
>>>>> Hi,
>>>>>
>>>>> On Wed, 2019-07-17 at 13:41 -0400, Zhengyu Gu wrote:
>>>>>> Currently, Shenandoah uses shared ParallelCleaningTask to perform
>>>>>> STW cleaning task, the cleaning task performs class unloading
>>>>>> along
>>>>>
>>>>> since the ParallelCleaningTask has originally moved from g1 code
>>>>> to shared to allow use with Shenandoah, now that the code is not
>>>>> used by Shenandoah any more, please move ParallelCleaningTask back
>>>>> to G1 specific code.
>>>>
>>>> Sure. Filed JDK-8227927.
>>>
>>> I would think that it is appropriate to include the move to G1 code
>>> part of this change, but I am okay if you want to do it separately.
>>>
>>> Thanks,
>>> Thomas
>>>
>>>
>
More information about the hotspot-gc-dev
mailing list