RFR (S): JDK-8228504: Rename max_rs_length to young_rs_length

Thomas Schatzl thomas.schatzl at oracle.com
Thu Jul 25 14:16:14 UTC 2019


Hi all,

  let me retract this change. Further looking at it showed that what
the prediction actually needs seems to be both young and total lengths,
or needs to be put much later in my current chain of changes.

Thanks,
  Thomas

On Thu, 2019-07-25 at 16:01 +0200, Thomas Schatzl wrote:
> Hi all,
> 
>   can I have reviews for this change that fixes the identifier
> "max_rs_length" across G1 code?
> 
> The problem with it is that it is no maximum of a single remembered
> set length, but a sum, and to clarify that it is supposed to be the
> sum of young gen remembered set lengths, this change calls it
> "young_rs_length".
> 
> With that change the issue in JDK-8228505, that we add old remembered
> set lengths to it during mixed gc, immediately stands out. Fixed in
> that change.
> 
> Based on JDK-8228503.
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8228504
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8228504/webrev/
> Testing:
> hs-tier1-3
> 
> Thanks,
>   Thomas
> 
> 





More information about the hotspot-gc-dev mailing list