RFR (S) 8228672: [TESTBUG] gc/metaspace/TestSizeTransitions.java fails on 32-bit platforms

Tony Printezis tprintezis at twitter.com
Tue Jul 30 16:36:14 UTC 2019


(trying again as I didn’t do Reply-All in the first attempt)

Thanks for looking into this.

Looks good. One suggestion: on a 32-bit platform when args[0] == true,
maybe make the test a nop? As is, you’ll basically run the same test twice
on 32-bit platforms.

And webrev.3 looks good. Only suggestion is to print “skipping test” or
something like that when you return.

Tony


—————
Tony Printezis | @TonyPrintezis | tprintezis at twitter.com


On July 29, 2019 at 4:31:00 PM, Aleksey Shipilev (shade at redhat.com) wrote:

Thanks for looking into this.

Looks good. One suggestion: on a 32-bit platform when args[0] == true,
maybe make the test a nop? As is, you’ll basically run the same test twice
on 32-bit platforms.

Tony



More information about the hotspot-gc-dev mailing list