RFR (S) 8228672: [TESTBUG] gc/metaspace/TestSizeTransitions.java fails on 32-bit platforms

Tony Printezis tprintezis at twitter.com
Tue Jul 30 16:52:22 UTC 2019


Looks good to me, thanks!


—————
Tony Printezis | @TonyPrintezis | tprintezis at twitter.com


On July 30, 2019 at 12:51:52 PM, Aleksey Shipilev (shade at redhat.com) wrote:

On 7/30/19 6:36 PM, Tony Printezis wrote:
> Looks good. One suggestion: on a 32-bit platform when args[0] == true,
maybe make the test a nop? As
> is, you’ll basically run the same test twice on 32-bit platforms.
>
> And webrev.3 looks good. Only suggestion is to print “skipping test” or
something like that when you
> return.

Right. Updated webrev.03 in place:
http://cr.openjdk.java.net/~shade/8228672/webrev.03/

-- 
Thanks,
-Aleksey



More information about the hotspot-gc-dev mailing list