Take 3: 8225716: G1 GC: Undefined behaviour in G1BlockOffsetTablePart::block_at_or_preceding

Andrew Haley aph at redhat.com
Mon Jun 17 15:35:44 UTC 2019

On 6/13/19 6:26 PM, Kim Barrett wrote:

> set_offset_array_raw looks quite uninterestingly different from
> set_offset_array (whose definition is in the .inline.hpp, near the
> definition of offset_array that needed to be changed). Consider
> hoisting set_offset_array_raw into set_offset_array, killing off the
> _raw function, and updating the one remaining caller.

Previous patch failed testing. We really do need
set_offset_array_raw(), not for efficiency but because at the very
start the assert invariants do not hold.

In this version of the patch set_offset_array_raw() is back and I had
to add a couple more const_casts in assertions. Fingers crossed.


Andrew Haley
Java Platform Lead Engineer
Red Hat UK Ltd. <https://www.redhat.com>
EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

More information about the hotspot-gc-dev mailing list