RFR 8224875: Shenandoah: ParallelCleaning code unloading should take lock to protect shared code roots array

[Aleksey Shipilev]

On 5/29/19 4:50 PM, Zhengyu Gu wrote:
>>
>>    assert_locked_or_safepoint(CodeCache_lock);
>>    ShenandoahSpinLocker locker(CodeCache_lock->owned_by_self() ? NULL : &_recorded_nms_lock);
> 
> Okay. http://cr.openjdk.java.net/~zgu/JDK-8224875/webrev.03/

Add a new line here:

 137       assert_locked_or_safepoint(CodeCache_lock);
 138       ShenandoahLocker locker(CodeCache_lock->owned_by_self() ? NULL : &_recorded_nms_lock);
 <here>
 139       ShenandoahNMethodOopDetector detector;

...and the whole thing is good to go in.

-Aleksey

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.org/pipermail/hotspot-gc-dev/attachments/20190529/033cfdfa/signature.asc>