RFR (M): 8189737: Make HeapRegion not derive from Space

Thomas Schatzl thomas.schatzl at oracle.com
Mon Nov 4 16:40:05 UTC 2019


Hi,

On 01.11.19 00:20, Thomas Schatzl wrote:
> Hi Kim,
> 
>    thanks for your review.
> 
> On Thu, 2019-10-31 at 18:12 -0400, Kim Barrett wrote:
>>> On Oct 31, 2019, at 9:43 AM, Thomas Schatzl <
>>> thomas.schatzl at oracle.com> wrote:
>>>
>>> Hi all,
>>>
>>>   can I get reviews for this refactoring that removes the
>>> inheritance of HeapRegion from Space?
>>>
>>>
> [...]
>>> CR:
>>> https://bugs.openjdk.java.net/browse/JDK-8189737
>>> Webrev:
>>> http://cr.openjdk.java.net/~tschatzl/8189737/webrev/
>>> Testing:
>>> hs-tier-1-5
>>>
>>> Thanks,
>>>   Thomas
[..]

>>
>> -------------------------------------------------------------------
>> -----------
>>
>> Looks good.
>>
>> I don't need a new webrev for the parameter list indentation fix.
>>
> 
> I will update the webrev later in place.

Done. Thanks for your review.

Thomas




More information about the hotspot-gc-dev mailing list