RFR: 8234232: [TESTBUG] gc/shenandoah/jvmti/TestHeapDump.java fails with -Xcomp

Jie Fu fujie at loongson.cn
Fri Nov 15 12:46:08 UTC 2019


Thanks Zhengyu for your review and sponsoring.

Please see the patch attached.

Thanks a lot.
Best regards,
Jie

On 2019/11/15 下午8:29, Zhengyu Gu wrote:
> Looks good.
>
> Please send me final patch, I will push for you.
>
> Thanks,
>
> -Zhengyu
>
> On 11/15/19 2:21 AM, Jie Fu wrote:
>> Hi all,
>>
>> May I get reviews for this small fix?
>>
>> JBS:    https://bugs.openjdk.java.net/browse/JDK-8234232
>> Webrev: http://cr.openjdk.java.net/~jiefu/8234232/webrev.00/
>>
>> And I need a sponsor.
>>
>> Thanks a lot.
>> Best regards,
>> Jie
>>
>>
>
-------------- next part --------------
# HG changeset patch
# User jiefu
# Date 1573821566 -28800
#      Fri Nov 15 20:39:26 2019 +0800
# Node ID 805888f0415f3519606d18ee0e61380c664e1e5c
# Parent  6f42d2a19117e61a10362315ffda6875187e3a20
8234232: [TESTBUG] gc/shenandoah/jvmti/TestHeapDump.java fails with -Xcomp
Reviewed-by: zgu

diff --git a/test/hotspot/jtreg/gc/shenandoah/jvmti/TestHeapDump.java b/test/hotspot/jtreg/gc/shenandoah/jvmti/TestHeapDump.java
--- a/test/hotspot/jtreg/gc/shenandoah/jvmti/TestHeapDump.java
+++ b/test/hotspot/jtreg/gc/shenandoah/jvmti/TestHeapDump.java
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2017, 2018, Red Hat, Inc. All rights reserved.
+ * Copyright (c) 2017, 2019, Red Hat, Inc. All rights reserved.
  *
  * This code is free software; you can redistribute it and/or modify it
  * under the terms of the GNU General Public License version 2 only, as
@@ -40,6 +40,8 @@
  * @run main/othervm/native/timeout=300 -agentlib:TestHeapDump -XX:+UnlockDiagnosticVMOptions -XX:+UnlockExperimentalVMOptions -XX:+UseShenandoahGC -Xmx128m -XX:ShenandoahGCHeuristics=aggressive -XX:-UseCompressedOops TestHeapDump
  */
 
+import java.lang.ref.Reference;
+
 public class TestHeapDump {
 
     private static final int NUM_ITER = 10000;
@@ -86,6 +88,8 @@
                 throw new RuntimeException("Expected " + EXPECTED_OBJECTS + " objects, but got " + numObjs);
             }
         }
+        Reference.reachabilityFence(array);
+        Reference.reachabilityFence(localRoot);
     }
 
     // We look for the instances of this class during the heap scan


More information about the hotspot-gc-dev mailing list