RFR: 8141637: Parallelize single threaded heap region iteration during Pre Evacuate Collection Set
Thomas Schatzl
thomas.schatzl at oracle.com
Tue Nov 19 09:27:56 UTC 2019
Hi Stefan,
On 19.11.19 10:23, Stefan Johansson wrote:
> Hi Thomas,
>
> On 2019-11-18 18:59, Thomas Schatzl wrote:
>> Hi Stefan,
>> [...]
>>
>>>
>>> Updated webrevs:
>>> Full: http://cr.openjdk.java.net/~sjohanss/8141637/01/
>>> Inc: http://cr.openjdk.java.net/~sjohanss/8141637/00-01/
>>>
>>
>> looks good.
>>
>> It would be nice to rename the G1RemSet::prepare_for_scan_heap_roots()
>> method to G1RemSet::exclude_from_scan() as we discussed internally in
>> this change too. It does not seem to warrant an extra CR, unless you
>> have more planned.
>>
>> I would not need a re-review for that rename, but you need to wait for
>> another reviewer anyway....
> Not sure how I missed to include that, fixed and here are the new webrevs:
> Full: http://cr.openjdk.java.net/~sjohanss/8141637/02
> Inc: http://cr.openjdk.java.net/~sjohanss/8141637/01-02
Looks good. Thanks.
Thomas
More information about the hotspot-gc-dev
mailing list