RFR: 8233029: Obsolete flag GCTaskTimeStampEntries
Kim Barrett
kim.barrett at oracle.com
Thu Nov 21 18:34:21 UTC 2019
> On Nov 21, 2019, at 1:12 PM, Leo Korinth <leo.korinth at oracle.com> wrote:
>
> Hi,
>
> When I changed ParallelGC to use WorkGangs instead of GCTasks, I unfortunately missed to remove (thereafter unused) command line option GCTaskTimeStampEntries. Here is a fix for that.
>
> CSR:
> https://bugs.openjdk.java.net/browse/JDK-8234396
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8233029
>
> Webrev:
> http://cr.openjdk.java.net/~lkorinth/8233029/00
>
> Testing:
> tier 1-3
>
> Thanks,
> Leo
------------------------------------------------------------------------------
test/hotspot/jtreg/gc/parallel/TestPrintGCDetailsVerbose.java
With the removal of -XX:GCTaskTimeStampEntries=1 from the second @run
line, we now have two identical @run lines.
That second @run with the additional option was added by JDK-8177963
"Parallel GC fails fast when per-thread task log overflows". Seems
like it's no longer relevant with the change to use WorkGang. So I
think the duplcate test can just be removed, rather than looking for
some other option(s) to make it different.
------------------------------------------------------------------------------
Other than that, looks good. I don't need a new webrev for removal of
the now duplicate test @run line.
More information about the hotspot-gc-dev
mailing list