RFR: 8233029: Obsolete flag GCTaskTimeStampEntries

Leo Korinth leo.korinth at oracle.com
Thu Nov 21 18:59:52 UTC 2019


On 21/11/2019 19:35, Thomas Schatzl wrote:
> Hi,
> 
> On 21.11.19 19:34, Kim Barrett wrote:
>>> On Nov 21, 2019, at 1:12 PM, Leo Korinth <leo.korinth at oracle.com> wrote:
>>>
>>> Hi,
>>>
>>> When I changed ParallelGC to use WorkGangs instead of GCTasks, I 
>>> unfortunately missed to remove (thereafter unused) command line 
>>> option GCTaskTimeStampEntries. Here is a fix for that.
>>>
>>> CSR:
>>> https://bugs.openjdk.java.net/browse/JDK-8234396
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8233029
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~lkorinth/8233029/00
>>>
> [...]
>> ------------------------------------------------------------------------------ 
>>
>> test/hotspot/jtreg/gc/parallel/TestPrintGCDetailsVerbose.java
>>
>> With the removal of -XX:GCTaskTimeStampEntries=1 from the second @run
>> line, we now have two identical @run lines.
>> [...]

oops

>> ------------------------------------------------------------------------------ 
>>
>>
>> Other than that, looks good.  I don't need a new webrev for removal of
>> the now duplicate test @run line.
>>
> 
> +1
> 
> Thomas

Thanks for your reviews Kim and Thomas.

/Leo



More information about the hotspot-gc-dev mailing list