RFR (S): 8234574: Rename prediction methods in G1Analytics

sangheon.kim at oracle.com sangheon.kim at oracle.com
Thu Nov 21 19:01:20 UTC 2019


Hi Thomas,

On 11/21/19 4:22 AM, Thomas Schatzl wrote:
> Hi all,
>
>   could you review this change that renames the prediction methods of 
> G1Analytics (and wrappers around them). This has been requested during 
> an internal review of JDK-8227434.
>
> This change has been split out to avoid re-reviewing later code 
> already reviewed but not pushed yet due to missing dependencies and 
> it's easier to review without functional changes mixed in.
>
> Based on JDK-8233588.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8234574
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8234574/webrev/
Renaming looks good.

If you are interested updating the copyright year, 
test_g1Predictions.cpp needs to be updated.
I don't need a new webrev for this.

Thanks,
Sangheon


> Testing:
> local compilation (this is a mechanical IDE supported rename of three 
> methods)
>
> Thanks,
>   Thomas




More information about the hotspot-gc-dev mailing list