RFR (M): 8233306: Sort members in G1's HeapRegion after removal of Space dependency

Thomas Schatzl thomas.schatzl at oracle.com
Fri Nov 22 08:58:29 UTC 2019


Hi Sangheon,

On 21.11.19 23:37, sangheon.kim at oracle.com wrote:
> Hi Thomas,
> 
> On 11/14/19 4:42 AM, Thomas Schatzl wrote:
>> Hi Stefan,
>>
[...]
>>   thanks for your review.
>>
>> Fyi, there has been one merge issue with latest NUMA changes: in 
>> heapRegion.cpp, in the initializer list of HeapRegion::HeapRegion, 
>> NUMA added a _node_index member at the end. This caused the merge 
>> logic to bail out because the context of the source hunk and the 
>> current code did not exactly match.
>>
>> I updated the webrev.
> The updated webrev looks good.
> 
> Thanks,
> Sangheon

   thanks for your review.

Thomas



More information about the hotspot-gc-dev mailing list