RFR (S): 8234179: Move HeapRegion::_recorded_rs_length/_predicted_elapsed_time_ms into G1CollectionSet
Thomas Schatzl
thomas.schatzl at oracle.com
Mon Nov 25 13:34:02 UTC 2019
Hi Leo,
On 22.11.19 17:37, Leo Korinth wrote:
> On 22/11/2019 10:57, Thomas Schatzl wrote:
>> Hi all,
>>
>> can I have reviews for this change that moves two members
>> (_recorded_rs_length/_predicted_elapsed_time_ms) of HeapRegion into
>> G1CollectionSet that is the only user of these members?
>>
>> This also allows more efficient allocation of this information in the
>> future, as these are only needed for eden regions.
>
> Looks good in general, the array _inc_collection_set_stats should be
> initialized though.
>
Good idea.
http://cr.openjdk.java.net/~tschatzl/8234179/webrev.0_to_1
http://cr.openjdk.java.net/~tschatzl/8234179/webrev.1
Now initializes the array with known bad values so that the asserts will
catch any use-before-init situations.
Passes hs-tier1-5
Thanks,
Thomas
More information about the hotspot-gc-dev
mailing list