RFR (S): 8233998: New young regions registered too early in collection set

sangheon.kim at oracle.com sangheon.kim at oracle.com
Mon Nov 25 21:57:01 UTC 2019


Hi Thomas,

On 11/22/19 4:58 AM, Thomas Schatzl wrote:
> Hi,
>
>   ping for a second review :)
>
> Thomas
>
> On 20.11.19 11:49, Thomas Schatzl wrote:
>> Hi,
>>
>> On 20.11.19 11:02, Stefan Johansson wrote:
>>> Hi Thomas,
>>>
>>> On 2019-11-12 16:24, Thomas Schatzl wrote:
>>>> Hi,
>>>>
>>>>    can I have reviews for this change that changes the place in 
>>>> which new mutator regions are published in the collection set list?
>>>>
>>>> Previously a new eden region has been published before some data 
>>>> that would be read by the young gen sampling thread could be visible.
>>>>
>>>> This change simply does the member updates before adding the 
>>>> regions to the collection set.
>>>>
>>>> CR:
>>>> https://bugs.openjdk.java.net/browse/JDK-8233998
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~tschatzl/8233998/webrev/
Looks good to me too.

Thanks,
Sangheon


>>> Looks good,
>>> StefanJ
>>
>>    thanks for your review.
>>
>> Thomas
>




More information about the hotspot-gc-dev mailing list