RFR (M): 8231579: G1's incremental calculation of region elapsed time always uses the same age group for prediction

Stefan Johansson stefan.johansson at oracle.com
Fri Nov 29 08:29:03 UTC 2019


Hi Thomas,

> 28 nov. 2019 kl. 18:39 skrev Thomas Schatzl <thomas.schatzl at oracle.com>:
> 
> Hi Kim,
> 
>  thanks for your review.
> 
> On 27.11.19 23:51, Kim Barrett wrote:
>>> On Nov 27, 2019, at 5:43 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>> 
>>>> On Nov 20, 2019, at 7:49 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>>> http://cr.openjdk.java.net/~tschatzl/8231579/webrev.0_to_1/ (diff)
>>>> http://cr.openjdk.java.net/~tschatzl/8231579/webrev.1/ (full)
>>>> 
>>>> Thanks,
>>>> Thomas
>>> 
>>> Looks good.
>> Oops, I did have one comment:
>> src/hotspot/share/gc/g1/g1Policy.cpp
>>  136   G1YoungLengthPredictor(bool during_cm,
>> After the other changes to that class, the during_cm constructor
>> argument seems to no longer be used.
> 
> Fixed in:
> 
> http://cr.openjdk.java.net/~tschatzl/8231579/webrev.1_to_2/ (diff)
> http://cr.openjdk.java.net/~tschatzl/8231579/webrev.2/ (full)
Still good,
Stefan

> 
> Thanks,
>  Thomas




More information about the hotspot-gc-dev mailing list