RFR (M): 8227739: Merge cost predictions for scanning cards and log buffer entries
Thomas Schatzl
thomas.schatzl at oracle.com
Fri Nov 29 08:56:46 UTC 2019
Hi Kim, Stefan,
On 29.11.19 09:31, Stefan Johansson wrote:
>
>
>> 28 nov. 2019 kl. 20:22 skrev Kim Barrett <kim.barrett at oracle.com>:
>>
>>> On Nov 28, 2019, at 6:13 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>>
>>> http://cr.openjdk.java.net/~tschatzl/8227739/webrev.1_to_2/ (diff)
>>> http://cr.openjdk.java.net/~tschatzl/8227739/webrev.2/ (full)
[...]
>>
>> That comment seems like it has some wording problems. It's also about
>> the store, so perhaps should be between lines 76 and 77. Maybe reword
>> something like
>>
>> Can use relaxed store because all racing threads are writing the same
>> value and there aren't any concurrent readers.
>> ------------------------------------------------------------------------------
>>
>> Looks good. I don't need a new webrev for futzing with the comment.
>>
>
> Looks good to me to and no need for further webrevs.
>
> Stefan
>
thanks for your reviews.
Thomas
More information about the hotspot-gc-dev
mailing list