RFR(XL): 8220310: Implementation: NUMA-Aware Memory Allocation for G1, Mutator (1/3)
sangheon.kim at oracle.com
sangheon.kim at oracle.com
Fri Oct 11 03:24:44 UTC 2019
Hi Thomas,
On 10/10/19 2:48 AM, Thomas Schatzl wrote:
> Hi,
>
> On 09.10.19 23:40, Stefan Johansson wrote:
>> Hi Sangheon,
>>
>> Thanks again for a much improved version. Some comments below.
>
> agree, it looks quite nice now.
:)
>
> [...]
>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~sangheki/8220310/webrev.3
>>> http://cr.openjdk.java.net/~sangheki/8220310/webrev.3.inc
> [...]
>>
>> src/hotspot/share/gc/g1/heapRegion.cpp
>> —
>> 462 if (UseNUMA) {
>> 463 const int* node_ids = G1MemoryNodeManager::mgr()->node_ids();
>> 464 st->print("|Node ID %02d", node_ids[this->node_index()]);
>> 465 }
>> 466 st->print_cr("”);
>>
>> I would prefer having a function that returns the node id given the
>> index. Like the inverse of index_of_node_id().
>>
>> I also think it would be more informative to say "NUMA id" or "NUMA
>> node”.
>
> I would also remove the "Node ID" string here as it does not convey
> any information. Most other columns also do not carry their description.
Done.
I will post the webrev after addressing Kim's comment.
Thanks,
Sangheon
>
> Thanks,
> Thomas
>
>
More information about the hotspot-gc-dev
mailing list