RFR: 8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest

Thomas Schatzl thomas.schatzl at oracle.com
Wed Oct 16 08:07:03 UTC 2019


Hi,

On 07.10.19 14:38, Per Liden wrote:
> This test is currently disabled for ZGC, but it can easily be enabled by 
> adjusting the expected log string. ZGC doesn't print "Pause Full", but 
> it still prints the "(Diagnostic Command)" part.
> 
Not sure if that checking only for that satisfies the requirements of 
the test. I mean that this is a test to verify that jcmd executes (or 
starts) a GC. I do not think checking for "(Diagnostic Command)" is 
enough - it could be any diagnostic command that could be executed.

What does ZGC print here? Can the check be made more specific?

> Also, the test enables gc=debug logging, which is unnecessary since this 
> is always printed on the gc=info level.
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8231943
> Webrev: http://cr.openjdk.java.net/~pliden/8231943/webrev.0
> 

Thanks,
   Thomas



More information about the hotspot-gc-dev mailing list