RFR: 8231943: ZGC: Enable serviceability/dcmd/gc/RunGCTest

[Per Liden]

On 10/16/19 1:13 PM, Thomas Schatzl wrote:
> Hi,
> 
> On 16.10.19 12:27, Per Liden wrote:
>> Hi Thomas,
>>
>> On 10/16/19 10:07 AM, Thomas Schatzl wrote:
>>> Hi,
>>>
>>> On 07.10.19 14:38, Per Liden wrote:
>>>> This test is currently disabled for ZGC, but it can easily be 
>>>> enabled by adjusting the expected log string. ZGC doesn't print 
>>>> "Pause Full", but it still prints the "(Diagnostic Command)" part.
>>>>
>>> Not sure if that checking only for that satisfies the requirements of 
>>> the test. I mean that this is a test to verify that jcmd executes (or 
>>> starts) a GC. I do not think checking for "(Diagnostic Command)" is 
>>> enough - it could be any diagnostic command that could be executed.
>>
>> I don't think that's quite true, since the file we're greping in is 
>> the GC log (not stdout), which we know only contains stuff from 
>> gc=info. So, only if the GC itself is printing "(Diagnostic Command)" 
>> on gc=info level somewhere else is this a problem, which I would find 
>> somewhat surprising, no?
> 
> Okay, ship it then :) Thanks for the clarification.

Ok, thanks for reviewing, Thomas!

/Per