RFR (S) 8232674: Fix build and rename ShenandoahBarrierSet::oop_load_from_native_barrier

[Aleksey Shipilev]

On 10/21/19 2:19 AM, Zhengyu Gu wrote:
> On 10/20/19 4:33 PM, Aleksey Shipilev wrote:
>> P1 bug:
>>    https://bugs.openjdk.java.net/browse/JDK-8232674
>>
>> I believe this is caused by missing definition of this method:
>>    oop oop_load_from_native_barrier(oop obj, narrowOop* load_addr);
> 
> This method should never been used. I thought I can get away with not implementing it (just like
> with gcc on Linux).
> 
> I think the method body should just be:
>  ...
>   ShouldNotReacheHere();
>   return NULL;
>  ...

Right! Let's do that:
 https://cr.openjdk.java.net/~shade/8232674/webrev.02/
   Testing: {Linux, Windows} x86_64 hotspot_gc_shenandoah; tier1 with Shenandoah

-- 
Thanks,
-Aleksey