RFR(M): 8220311: Implementation: NUMA-Aware Memory Allocation for G1, Survivor (2/3)

Thomas Schatzl thomas.schatzl at oracle.com
Tue Oct 22 17:06:45 UTC 2019


Hi,

On 22.10.19 18:47, sangheon.kim at oracle.com wrote:
> Hi Kim,
> 
> On 10/22/19 12:19 AM, Kim Barrett wrote:
>>> On Oct 22, 2019, at 1:52 AM, sangheon.kim at oracle.com wrote:
>>> What do you think about below comment?
>>>
>>>    // Tries to allocate word_sz in the PLAB of the next "generation" 
>>> after trying to
>>>    // allocate into dest. Previous_plab_refill_failed indicates 
>>> whether previous
>>>    // PLAB refill for the original (source) object was failed.
>> Drop “was”.  Otherwise looks good.
> Done.
> 
> Webrev:
> http://cr.openjdk.java.net/~sangheki/8220311/webrev.3
> http://cr.openjdk.java.net/~sangheki/8220311/webrev.3.inc
> 

   still good :)

Thomas



More information about the hotspot-gc-dev mailing list