RFR (S): 8232777: Rename G1Policy::_max_rs_length as it is no maximum

Kim Barrett kim.barrett at oracle.com
Tue Oct 22 19:16:37 UTC 2019


> On Oct 22, 2019, at 2:02 PM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
> Hi all,
> 
>  can I have reviews for this small cleanup that renames G1Policy::_max_rs_length to just _rs_length because the contained value is simply no maximum. This causes some confusion down the line in its use (imo).
> 
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8232777
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8232777/webrev/
> Testing:
> local compilation
> 
> Thanks,
>  Thomas

You missed one in a comment:
src/hotspot/share/gc/g1/g1Policy.cpp
 757     // This is defensive. For a while _max_rs_length could get

Otherwise than that, looks good, and trivial.




More information about the hotspot-gc-dev mailing list