RFR (XS): 8232951: TestG1ParallelPhases.java fails with phase NonYoungFreeCSet not found

Kim Barrett kim.barrett at oracle.com
Sat Oct 26 01:51:43 UTC 2019


> On Oct 24, 2019, at 7:50 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> […]
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8232951
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8232951/webrev/
> Testing:
> 400 runs of the changed test without issues
> 
> Thanks,
>  Thomas

I'd not previously noticed the AlwaysTenure and NeverTenure options.
So many options...

Those options are documented as being ParallelGC only.  But it looks
like setting either of them forces a value for MaxTenuringThreshold,
so it seems okay to change the test to use AlwaysTenure.  The
documentation for the options should be updated though.  (That can be
a separate RFE.)

Please put the new -Xlog option on a separate line.  I know we don't
have an official line length limit, but 152 chars seems excessive to
me, and forced me to scroll to see some of it.

Other than that, looks good.  I don't need a new webrev.




More information about the hotspot-gc-dev mailing list