RFR (XS) 8233303: Shenandoah: verifier assert erroneously uses byte_size_in_exact_unit
Roman Kennke
rkennke at redhat.com
Thu Oct 31 09:17:25 UTC 2019
Ok.
Thanks,
Roman
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8233303
>
> Typo in JDK-8232102 found by sh/jdk8 backports, where byte_size_in_exact_unit is not defined. Should
> actually be "proper_unit".
>
> Fix:
>
> diff -r b026a43e1809 src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp
> --- a/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp Tue Oct 29 09:34:23 2019 +0800
> +++ b/src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp Thu Oct 31 10:08:22 2019 +0100
> @@ -693,12 +693,12 @@
>
> size_t heap_committed = _heap->committed();
> guarantee(cl.committed() == heap_committed,
> "%s: heap committed size must be consistent: heap-committed = " SIZE_FORMAT "%s,
> regions-committed = " SIZE_FORMAT "%s",
> label,
> - byte_size_in_exact_unit(heap_committed), proper_unit_for_byte_size(heap_committed),
> - byte_size_in_exact_unit(cl.committed()), proper_unit_for_byte_size(cl.committed()));
> + byte_size_in_proper_unit(heap_committed), proper_unit_for_byte_size(heap_committed),
> + byte_size_in_proper_unit(cl.committed()), proper_unit_for_byte_size(cl.committed()));
> }
>
> // Internal heap region checks
> if (ShenandoahVerifyLevel >= 1) {
> ShenandoahVerifyHeapRegionClosure cl(label, regions);
>
> Testing: x86_64 build
>
More information about the hotspot-gc-dev
mailing list