RFR: JDK-8231447: Shenandoah: Compilation-time regression after JDK-8231086

Roman Kennke rkennke at redhat.com
Wed Sep 25 10:29:00 UTC 2019


> On 9/25/19 12:11 PM, Roman Kennke wrote:
>> http://cr.openjdk.java.net/~rkennke/JDK-8231447/webrev.00/
> 
> Looks okay.
> 
> *) The include guard is not correct in shenandoahBarrierSetClone.inline.hpp:
> 
>    24 #ifndef SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_HPP
>    25 #define SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_HPP
>    ...
>    98 #endif // SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_HPP
> 
> Should be SHARE_GC_SHENANDOAH_SHENANDOAHBARRIERSETCLONE_INLINE_HPP?

Right:
http://cr.openjdk.java.net/~rkennke/JDK-8231447/webrev.01/

> *) Does this compile with --disable-precompiled-headers?

yes.

Good?

Roman



More information about the hotspot-gc-dev mailing list