RFR: 8241976: Add test for GCPhaseConcurrentLevel1 JFR event

Per Liden per.liden at oracle.com
Wed Apr 1 09:14:22 UTC 2020


Hi,

On 4/1/20 10:58 AM, Stefan Karlsson wrote:
> Hi all,
> 
> Please review this patch to add a test for the new 
> GCPhaseConcurrentLevel1 JFR event.
> 
> https://cr.openjdk.java.net/~stefank/8241976/webrev.01/
> https://bugs.openjdk.java.net/browse/JDK-8241976


-            "GCPhasePauseLevel4", "GCPhaseConcurrent")
+            "GCPhasePauseLevel4", "GCPhaseConcurrent", 
"GCPhaseConcurrentLevel1")

I don't think this is right, is it? Since you have a test for now, I 
think you want to remove both "GCPhaseConcurrent" and 
"GCPhaseConcurrentLevel1" from that list, right?

While I'm at it, I think "-Xms32M -Xmx256M" could just be "-Xmx32M" like 
most other event tests that doesn't have any special needs.

cheers,
Per

> 
> This also fixes the test failure in 
> test/jdk/jdk/jfr/event/metadata/TestLookForUntestedEvents.java, where 
> the test complains that the JFR event isn't tested. I'd like to push 
> this patch ASAP to fix that failure.
> 
> Thanks,
> StefanK



More information about the hotspot-gc-dev mailing list