RFR: 8241141: Restructure humongous object allocation in G1
Stefan Johansson
stefan.johansson at oracle.com
Wed Apr 8 13:54:10 UTC 2020
Thanks for the review Thomas,
Updated webrevs:
Full: http://cr.openjdk.java.net/~sjohanss/8241141/03/
Inc: http://cr.openjdk.java.net/~sjohanss/8241141/02-03/
On 2020-04-08 10:42, Thomas Schatzl wrote:
> Hi,
>
> On 07.04.20 16:02, Stefan Johansson wrote:
>> New webrevs incorporating the new suggested search from Kim:
>> Full: http://cr.openjdk.java.net/~sjohanss/8241141/02/
>> Inc: http://cr.openjdk.java.net/~sjohanss/8241141/01-02/
>>
>
> - could you please remove the newline after the return parameter in
> g1CollectedHeap.cpp:211 while we are touching this code?
>
> - in heapRegionManager.hpp I would like to ask to make the parameter
> name indicating the number of regions uniform. I.e. the change adds
> "num" and "regions" to the existing "num_regions" (and it also sometimes
> uses num_regions) for this kind of parameter for no apparent reason.
>
Fixed.
Cheers,
Stefan
> Looks good otherwise.
More information about the hotspot-gc-dev
mailing list