RFR: 8241141: Restructure humongous object allocation in G1
Kim Barrett
kim.barrett at oracle.com
Thu Apr 9 23:59:58 UTC 2020
> On Apr 9, 2020, at 7:05 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
>
>
>
> On 2020-04-09 00:53, Kim Barrett wrote:
>>> On Apr 8, 2020, at 9:54 AM, Stefan Johansson <stefan.johansson at oracle.com> wrote:
>>>
>>> Thanks for the review Thomas,
>>>
>>> Updated webrevs:
>>> Full: http://cr.openjdk.java.net/~sjohanss/8241141/03/
>>> Inc: http://cr.openjdk.java.net/~sjohanss/8241141/02-03/
>> Looks good.
>> One last thing though. It seems like guarantee_contiguous_range should
>> be assert_contiguous_range and do an ASSERT-only check. It's really a
>> post-condition check on the algorithm's correctness. Sorry I didn't
>> notice this before. I don't need a new webrev if you decide to make
>> this change.
> Sorry, I pushed this last night since we were in agreement on the meeting. I filed an enhancement (JDK-8242448) for this. I was also thinking about changing this but since the old code used a guarantee I kept it that way. I'll send out an RFR soon.
Thanks for following up on it.
More information about the hotspot-gc-dev
mailing list