RFR: 8228991: Obsolete -XX:UseAdaptiveGCBoundary

Kim Barrett kim.barrett at oracle.com
Wed Apr 15 14:24:55 UTC 2020


> On Apr 15, 2020, at 6:54 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
> 
> On 2020-04-15 12:53, Kim Barrett wrote:
>>> On Apr 15, 2020, at 5:40 AM, Stefan Karlsson <stefan.karlsson at oracle.com> wrote:
>>> I found a lot of dead/unneeded code when following the trails of what you removed. It was too much to describe, so I created a patch for it instead:
>>> https://cr.openjdk.java.net/~stefank/8228991/webrev.01/
>> You are right, there’s more dead code there.  I hadn’t noticed that after my changes
>> AdjoiningGeneration was only used to provide construction of the PS{Young,Old}Gen
>> objects, which then get pulled out and cached and the  AdjoiningGeneration object
>> is unused after that.
>> 
>>> Main change in the patch:
>>> - Removes AdjoiningGenerations, AdjoiningVirtualSpaces, PSVirtualSpaceHighToLow
>>> - Cleans up PS{Young,Old}Gen
>>> -- Removes most virtual declarations from Removes
>>> -- Moves PS{Young,Old}Gen initialization to constructor and makes initilization functions private.
>>> -- protected -> private
>>> 
>>> Should I propose this as a follow-up cleanup?
>> We could do that, or I could merge your changes into mine and do it all at once.
>> Reviewing might be easier as two steps, esp. since you and Thomas have already
>> looked the initial set of changes.  I’m fine with either, though if done as two steps
>> I’m going to skip some of Thomas’s comments, since they apply to stuff that’s just
>> going to get deleted by the followup.
> 
> Let's take it in two steps then, just to make future archeology easier.

OK.




More information about the hotspot-gc-dev mailing list